feat(config): add shared load_entry_point utility for declarative config plugin loading#5093
Open
MikeGoldsmith wants to merge 3 commits intoopen-telemetry:mainfrom
Open
Conversation
Extracts a generic `load_entry_point(group, name)` helper into `_common` so that resource detector, exporter, propagator, and sampler plugin loading in declarative file config can all use the same entry point lookup pattern rather than duplicating it. Refactors `_propagator.py` to use the new util, removing its inline entry point lookup. Assisted-by: Claude Sonnet 4.6
Assisted-by: Claude Sonnet 4.6
github-project-automation
bot
moved this from Easy to review / merge / close
to Approved PRs
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a shared
load_entry_point(group, name)helper to_common.pyfor loading plugins via entry points in declarative file configuration. Refactors_propagator.pyto use it, removing the duplicated inline implementation.This utility will be used by upcoming PRs for generic plugin loading support:
cc @ravitheja4531-cell — this utility is intended to support your work on #5053. Rather than implementing the entry point lookup inline, you can use
load_entry_point("opentelemetry_resource_detector", name)from_commonand it will handle the error wrapping for you.Type of change
How Has This Been Tested?
TestLoadEntryPointtests intest_common.pycovering: successful load, not-found error, and load exception wrappingtest_propagator.pypatch targets to reflect the movedentry_pointsimportDoes This PR Require a Contrib Repo Change?
Checklist: